Fix for child tables display error #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeverley
reviewed
Oct 11, 2023
| let element = $(this) | ||
| if(!element.is(":hidden")) { | ||
| element.toggle(); | ||
| } |
There was a problem hiding this comment.
As discussed, please try replacing all this with hide()
abeverley
reviewed
Oct 11, 2023
| if(parent && parent.children().length==1) { | ||
| const child = parent.children('.odd').children('.dataTables_empty'); | ||
| if(child.is(':hidden')) { | ||
| child.show(); |
There was a problem hiding this comment.
Consider simplifying with parent.find('.dataTables_empty').show()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1351 (Brass) - not removing "no data present" on data added to child table (and adding it again after all child data is removed).